I need help with this script

[timle]

Let>PuzzleCode=pr
Let>directory=c:\test

GetFileList>%directory%\*.*,files
Separate>files,;,oldname

MidStr>%oldname%,3,8,value1
MidStr>%oldname%,3,2,value2
MidStr>%oldname%,6,2,value3
Let>newname=%PuzzleCode%%value1%%PuzzleCode%%value2%%value3%puzzle.eps

CopyFile>oldname,newname

[Marcus Tettmar]

Separate creates an array. Your example splits the list "files" into array "oldname". So you end up with oldname_1, oldname_2 .... oldname_count

So youre MidStr commands won't work. oldname is not a variable. I expect you actually intend to operate on each element of the array inside a loop?

Something like:

Code: Select all

Let>PuzzleCode=pr
Let>directory=c:\test

GetFileList>%directory%\*.*,files
Separate>files,;,oldname

Let>k=1
Repeat>k
  Let>thisfile=oldname_%k%
  MidStr>%thisfile%,3,8,value1
  MidStr>%thisfile%,3,2,value2
  MidStr>%thisfile%,6,2,value3 
  Let>newname=%PuzzleCode%%value1%%PuzzleCode%%value2%%value3%puzzle.eps
  CopyFile>oldname,newname
  Let>k=k+1
Until>k>oldname_count

But I'm guessing because I'm not really sure what you are trying to do ...

[timle]

The script did not do any thing.
I would like to change the old name to the new name, but it did not work

I must have over look something...

====================================
//objective
//file name is: cm09_16___cmNYTpuz
//need to change to: pr09_16___pr0916puzzle


Let>PuzzleCode=pr
Let>directory=c:\comictest

GetFileList>%directory\%*.*,files
Separate>files,;,oldname

Let>k=1
Repeat>k
Let>thisfile=oldname_%k%
MidStr>%thisfile%,3,8,value1
MidStr>%thisfile%,3,2,value2
MidStr>%thisfile%,6,2,value3
Let>newname=%PuzzleCode%%value1%%PuzzleCode%%value2%%value3%puzzle.eps
CopyFile>oldname,newname
Let>k=k+1
Until>k>oldname_count

[Me_again]

I didn't test the rename part but the reason it won't do anything is that you have a typo in this line:

GetFileList>%directory\%*.*,files

should be this:

GetFileList>%directory%\*.*,files

[Marcus Tettmar]

http://www.mjtnet.com/blog/2007/09/12/d ... bug-debug/

[timle]

the debug helps alot!!!

[timle]

I got the script working, but it did not process all files in the directory. If I have 3 files in the directory, it only process 2

thanks


Let>PuzzleCode=pr

GetFileList>c:\comictest\*.*,files
Separate>files,;,oldname


Let>k=0
Repeat>k
Let>thisfile=oldname_%k%
MidStr>%thisfile%,16,2,value1
MidStr>%thisfile%,19,2,value2
Let>newname=%PuzzleCode%%value1%_%value2%___%PuzzleCode%%value1%%value2%puzzle.eps
CopyFile>%thisfile%,c:\comictest\%newname%
Let>k=k+1
Until>k,oldname_count

[Marcus Tettmar]

Change your Until line to:

Until>k>oldname_count

...

Or initialise k to 0 and increment at the start of the loop instead of the end.

[timle]

thank you